Add CUDA context support and build configuration #3567
+604
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds CUDA context management files (cuda_context.h and cuda_context.cpp) that provide similar functionality to the existing OpenCL context. The changes include: - CudaContext class inheriting from Context and Singleton - CUDA kernel management and execution interfaces - Build system updates to support CUDA with enable-cuda option - Conditional linking of CUDA runtime library for both Windows and Linux - Addition of enable-cuda option in meson_options.txt Signed-off-by: Daekyoung Jung <[email protected]>
dkjung
requested review from
DonghakPark,
EunjuYang,
SeoHyungjun,
again4you,
anyj0527,
baek2sm,
djeong20,
gichan-jang,
haehun,
jaeyun-jung,
jihochu,
jijoongmoon,
leemgs,
lhs8928,
myungjoo,
skykongkong8,
songgot and
wooksong
as code owners
Collaborator
|
Could you check the CI and then We will review once all the ci pass. |
Contributor
|
I think the commit body of bc7cec0 is missing. Please add some messages to the body instead of putting all messages in the title. |
Contributor
|
Please check the comments in #3562 |
myungjoo
reviewed
Nov 19, 2025
| foreach kernel : cuda_sources | ||
| obj_name = kernel.replace('.cu', '.o') | ||
| obj = custom_target(obj_name, | ||
| command: [nvcc, '-c', '-Xcompiler', '/MD', '@INPUT@', '-o', '@OUTPUT@'], |
Member
There was a problem hiding this comment.
/MD is for MSVC++. This expression should check if it's for Windows/MSVCC++.
For linux, add appropriate compiler option (-fPIC ? )
myungjoo
reviewed
Nov 19, 2025
| #endif | ||
|
|
||
| #ifdef ENABLE_CUDA | ||
| auto &cuda_context = nntrainer::CudaContext::Global(); |
Member
There was a problem hiding this comment.
This may need to add #include "cuda_context.h".
myungjoo
reviewed
Nov 19, 2025
| namespace nntrainer { | ||
| std::mutex cuda_factory_mutex; | ||
|
|
||
| void CudaContext::initialize() noexcept { |
Member
There was a problem hiding this comment.
Is it ok to let the caller of initialize() unaware of the init error?
This commit adds CUDA context management files (cuda_context.h and cuda_context.cpp) that provide similar functionality to the existing OpenCL context. The changes include: - Implementation of CudaContext class inheriting from Context and Singleton - CUDA kernel management and execution interface - Build system updates to support CUDA with enable-cuda meson_options - Conditional linking of CUDA runtime library for both Windows and Linux - Addition of enable-cuda option in meson_options.txt - Implementation of RMSNorm CUDA kernel and build configuration Signed-off-by: Daekyoung Jung <[email protected]>
dkjung
force-pushed
the
feature/cuda2
branch
from
bc7cec0 to
42922de
Compare
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CUDA context management files (cuda_context.h and cuda_context.cpp) that provide similar functionality to the existing OpenCL context. The changes include:
Signed-off-by: Daekyoung Jung [email protected]